<table><tr><td style="">jnoack created this revision.<br />jnoack added a reviewer: ach.<br />Restricted Application added a subscriber: Konsole.<br />Restricted Application added a project: Konsole.<br />jnoack requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11241">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p><a href="https://phabricator.kde.org/D10935" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D10935</a> introduced KMessageWidgets in TerminalDisplay. This patch restores the <br />
default close button and makes use of animateShow/animateHide. A nice plus is <br />
that I also removed some code which has become obsolete AND that the <br />
messages are now animated.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Show/hide works like before.<br />
Also still works if readonly and suspended at the same time.<br />
Detaching works.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>BRANCH</strong><div><div>use-default-messagewidget-close-action</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11241">https://phabricator.kde.org/D11241</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/TerminalDisplay.cpp<br />
src/TerminalDisplay.h</div></div></div><br /><div><strong>To: </strong>jnoack, ach<br /><strong>Cc: </strong>ach, Konsole, herrold, ngraham, hindenburg<br /></div>