D10862: Konsole: Add read-only mode

[Joshua Noack]

jnoack added a comment.


  In D10862#216038 <https://phabricator.kde.org/D10862#216038>, @hindenburg wrote:
  
  > 1. You have to increase the *rc version or the new files don't get installed
  
  
  Just bumping is enough, right. Noted.
  
  > 2. Drag and drop the ro tab undos the ro
  
  Hm... Drag and Drop is weird, even now Konsole is buggy when dragging a tab and CTRL+S is active. Will look into it.
  
  > 3. The current patch has no warning, correct?  I did see the recent patch to use kmessagewidget
  
  Yes, because I touched the QLabel warning as well and changed the layout behaviour. Can't commit it separately without writing throwaway code.
  
  > 4 . Changing the tab icon to the lock version would be nice IMHO
  
  Noted.
  
  > 5 . Add the lock option when right clicking on tab
  
  Noted.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D10862

To: jnoack, #konsole, hindenburg
Cc: hindenburg, ngraham, #konsole
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180301/0f039721/attachment.html>