<table><tr><td style="">jnoack added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D10862" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D10862#216038" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D10862#216038</a>, <a href="https://phabricator.kde.org/p/hindenburg/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@hindenburg</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><ol class="remarkup-list">
<li class="remarkup-list-item">You have to increase the *rc version or the new files don't get installed</li>
</ol></div>
</blockquote>
<p>Just bumping is enough, right. Noted.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ol class="remarkup-list" start="2">
<li class="remarkup-list-item">Drag and drop the ro tab undos the ro</li>
</ol></blockquote>
<p>Hm... Drag and Drop is weird, even now Konsole is buggy when dragging a tab and CTRL+S is active. Will look into it.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ol class="remarkup-list" start="3">
<li class="remarkup-list-item">The current patch has no warning, correct? I did see the recent patch to use kmessagewidget</li>
</ol></blockquote>
<p>Yes, because I touched the QLabel warning as well and changed the layout behaviour. Can't commit it separately without writing throwaway code.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>4 . Changing the tab icon to the lock version would be nice IMHO</p></blockquote>
<p>Noted.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>5 . Add the lock option when right clicking on tab</p></blockquote>
<p>Noted.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D10862" rel="noreferrer">https://phabricator.kde.org/D10862</a></div></div><br /><div><strong>To: </strong>jnoack, Konsole, hindenburg<br /><strong>Cc: </strong>hindenburg, ngraham, Konsole<br /></div>