D13620: fix potential crash

[Martin Tobias Holmedahl Sandsmark]

sandsmark created this revision.
sandsmark added reviewers: Konsole, hindenburg, tcanabrava.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
sandsmark requested review of this revision.

REVISION SUMMARY
  revert the change to allocate the dialog on the stack, the original code was that way for a reason:
  
  https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
  
  there's some other minor issues with the patch set, but I don't think they're going to cause crashes.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13620

AFFECTED FILES
  settings/ProfileSettings.cpp

To: sandsmark, #konsole, hindenburg, tcanabrava
Cc: konsole-devel, #konsole, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180619/681e6e9d/attachment.html>