<table><tr><td style="">sandsmark created this revision.<br />sandsmark added reviewers: Konsole, hindenburg, tcanabrava.<br />Restricted Application added a project: Konsole.<br />Restricted Application added a subscriber: konsole-devel.<br />sandsmark requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13620">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>revert the change to allocate the dialog on the stack, the original code was that way for a reason:</p>

<p><a href="https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0" class="remarkup-link" target="_blank" rel="noreferrer">https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0</a></p>

<p>there's some other minor issues with the patch set, but I don't think they're going to cause crashes.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13620">https://phabricator.kde.org/D13620</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>settings/ProfileSettings.cpp</div></div></div><br /><div><strong>To: </strong>sandsmark, Konsole, hindenburg, tcanabrava<br /><strong>Cc: </strong>konsole-devel, Konsole, herrold, ngraham, maximilianocuria, hindenburg<br /></div>