D12968: Remove triplicated code
Kurt Hindenburg
noreply at phabricator.kde.org
Thu Jun 14 13:13:25 UTC 2018
hindenburg added a comment.
In D12968#278262 <https://phabricator.kde.org/D12968#278262>, @tcanabrava wrote:
> and window->createSession calls ViewManager::newSession that calls
> session->addEnvironmentEntry(QStringLiteral("KONSOLE_DBUS_WINDOW=/Windows/%1").arg(managerId()));
>
> that's the reason I said it's strange that the KONSOLE_DBUS_WINDOW is not set, as the only codepoint that I can follow always sets it.
Yes, I'd have to debug this more to see why the addEnvironmentEntry doesn't appear be saved. We don't need to hold up this patch IMHO
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D12968
To: tcanabrava, #konsole, hindenburg
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180614/c02ffa67/attachment.html>
More information about the konsole-devel
mailing list