D12968: Remove triplicated code

[Tomaz Canabrava]

tcanabrava added a comment.


  In D12968#278225 <https://phabricator.kde.org/D12968#278225>, @hindenburg wrote:
  
  > In D12968#277887 <https://phabricator.kde.org/D12968#277887>, @tcanabrava wrote:
  >
  > >   > Having a Konsole open and then logging off your desktop; when you log back in, the Konsole should be restored
  > >   
  > >
  > > I found the code that deals with that:
  > >
  > >   void restoreSession(Application &app)
  > >   {
  > >       int n = 1;
  > >       while (KMainWindow::canBeRestored(n)) {
  > >           app.newMainWindow()->restore(n++);
  > >       }
  > >   }
  > >
  >
  >
  > Application::newMainWindow, it calls this
  >
  >   connect(window, &Konsole::MainWindow::newWindowRequest, this,
  >           &Konsole::Application::createWindow);
  >   
  >
  > createWindow:
  >
  >   MainWindow *window = newMainWindow();
  >   window->createSession(profile, directory);
  >   finalizeNewMainWindow(window);
  
  
  and window->createSession calls ViewManager::newSession that calls     
  session->addEnvironmentEntry(QStringLiteral("KONSOLE_DBUS_WINDOW=/Windows/%1").arg(managerId()));
  
  that's the reason I said it's strange that the KONSOLE_DBUS_WINDOW is not set, as the only codepoint that I can follow always sets it.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12968

To: tcanabrava, #konsole, hindenburg
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180614/f2e1075f/attachment.html>