D13516: simplify isProfileDeletable

Ahmad Samir noreply at phabricator.kde.org
Thu Jun 14 08:09:25 UTC 2018


ahmadsamir added inline comments.

INLINE COMMENTS

> tcanabrava wrote in ProfileSettings.cpp:385
> Considering that the code works right now, it’s returning true when we don’t have a profile. While I agree with your reasoning I tried to port the code without changing its behavior.

Yeah, well, this is still a good time to change it, if the change makes more sense.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13516

To: tcanabrava, #konsole, hindenburg
Cc: ahmadsamir, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180614/228d39d0/attachment.html>


More information about the konsole-devel mailing list