D13516: simplify isProfileDeletable

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> ProfileSettings.cpp:385
> +    if (!profile) {
> +        return true;
> +    }

I think that if the profile pointer is null, it should return false, otherwise you'd be deleting some unknown .profile.

> ProfileSettings.cpp:390
> +    if (!fileInfo.exists()) {
>          return true;
>      }

Same thing here, should be false (if the .profile doesn't exist to begin with it can't be deleted).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13516

To: tcanabrava, #konsole, hindenburg
Cc: ahmadsamir, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180613/cddb241e/attachment.html>