D12968: Remove triplicated code

Tomaz Canabrava noreply at phabricator.kde.org
Wed Jun 13 13:44:30 UTC 2018


tcanabrava added a comment.


  In D12968#277762 <https://phabricator.kde.org/D12968#277762>, @hindenburg wrote:
  
  > Ok, haven't found any regressions.  The below item should be fixed later as I didn't realize it before.
  >
  > While testing this, I notice Konsole on desktop session restore and demo_konsolepart, KONSOLE_DBUS_WINDOW is not set.
  
  
  While looking for this I'v found a 4rth time the same code was duplicated in the Konsole codebase, but on the parts it didn't set the KONSOLE_DBUS_WINDOW, I'v fixed by calling the SessionManager method and removing duplication.
  For the restore window part - how do I test this?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12968

To: tcanabrava, #konsole, hindenburg
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180613/43dc333e/attachment.html>


More information about the konsole-devel mailing list