<table><tr><td style="">tcanabrava added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12968">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12968#277762" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12968#277762</a>, <a href="https://phabricator.kde.org/p/hindenburg/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@hindenburg</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Ok, haven't found any regressions. The below item should be fixed later as I didn't realize it before.</p>
<p>While testing this, I notice Konsole on desktop session restore and demo_konsolepart, KONSOLE_DBUS_WINDOW is not set.</p></div>
</blockquote>
<p>While looking for this I'v found a 4rth time the same code was duplicated in the Konsole codebase, but on the parts it didn't set the KONSOLE_DBUS_WINDOW, I'v fixed by calling the SessionManager method and removing duplication.<br />
For the restore window part - how do I test this?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12968">https://phabricator.kde.org/D12968</a></div></div><br /><div><strong>To: </strong>tcanabrava, Konsole, hindenburg<br /><strong>Cc: </strong>konsole-devel, herrold, ngraham, maximilianocuria, hindenburg<br /></div>