D13428: De duplicate setContainerFeatures

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> ViewManager.cpp:1287
>  
>      foreach (ViewContainer *container, _viewSplitter->containers()) {
> +        setContainerFeatures(container);

Since you're touching this bit of code anyway, this might be a good time to replace foreach (which is being deprecated) with a range-for loop.
http://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH
https://www.kdab.com/goodbye-q_foreach/

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13428

To: tcanabrava, hindenburg, #konsole
Cc: ahmadsamir, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180608/df4aa7a0/attachment.html>