<table><tr><td style="">ahmadsamir added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13428">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13428#inline-70087">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ViewManager.cpp:1287</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">foreach</span> <span class="p">(</span><span class="n">ViewContainer</span> <span style="color: #aa2211">*</span><span class="n">container</span><span class="p">,</span> <span class="n">_viewSplitter</span><span style="color: #aa2211">-></span><span class="n">containers</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">setContainerFeatures</span><span class="p">(</span><span class="n">container</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since you're touching this bit of code anyway, this might be a good time to replace foreach (which is being deprecated) with a range-for loop.<br />
<a href="http://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH" class="remarkup-link" target="_blank" rel="noreferrer">http://doc.qt.io/qt-5/qtglobal.html#Q_FOREACH</a><br />
<a href="https://www.kdab.com/goodbye-q_foreach/" class="remarkup-link" target="_blank" rel="noreferrer">https://www.kdab.com/goodbye-q_foreach/</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R319 Konsole</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13428">https://phabricator.kde.org/D13428</a></div></div><br /><div><strong>To: </strong>tcanabrava, hindenburg, Konsole<br /><strong>Cc: </strong>ahmadsamir, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg<br /></div>