D17781: Don't change alternate scrolling state after calling reset()

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Konsole, hindenburg.
Herald added a project: Konsole.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Alternate Scrolling shouldn't be reset when calling resetModes(), this
  is to maintain the profile alternate scrolling property after reset()
  is called, otherwise calling reset() (or clear scrollback and reset)
  will always make alternate scrolling get disabled regardless of the
  respective profile property.
  
  Also this matches XTerm behavior.
  
  BUG: 402461

TEST PLAN
  1 - Open a new tab and make sure the alternate scrolling profile property
  
    is enabled
  
  2 - Run less or any other application that uses the alternate screen, scrolling
  
    with the mouse should work
  
  3 - Quit the previous application and execute `reset`
  4 - Repeat 2, notice that now scrolling doesn't work
  
  After applying the patch, alternate scrolling mode is not changed after calling
  reset.

REPOSITORY
  R319 Konsole

BRANCH
  alternate-scrolling-after-reset

REVISION DETAIL
  https://phabricator.kde.org/D17781

AFFECTED FILES
  src/Vt102Emulation.cpp

To: ahmadsamir, #konsole, hindenburg
Cc: konsole-devel, hindenburg, thsurrel, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181224/635e5549/attachment-0001.html>