D17492: Be explicit on what the ViewContainer accepts

[Tomaz Canabrava]

Before 7a43e3b2cde05a7 the tabs where mirrors of sessions, so more
than one tab could belong to the same session controller, this is not
true anymore, a tab has it's own TerminalDisplay / SessionManager
pair.

On Wed, Dec 12, 2018 at 5:02 PM Kurt Hindenburg
<noreply at phabricator.kde.org> wrote:
>
> hindenburg added a comment. View Revision
>
> If you can comment on the foreach removals, I don't see any other issues ATM
>
>
> INLINE COMMENTS
> View InlineViewContainer.cpp:471
> {
> foreach (QWidget *widget, widgetsForItem(item)) {
> const int index = indexOf(widget);
> auto controller = qobject_cast<SessionController*>(item);
> auto index = indexOf(controller->view());
>
> The only think that looks odd to me is you removed a couple of these foreach widgetsForItems loops. Are you sure that's what you wanted?
>
> 471, 489, 493
>
>
> REPOSITORY
> R319 Konsole
>
> REVISION DETAIL
> https://phabricator.kde.org/D17492
>
> To: tcanabrava, Konsole, hindenburg
> Cc: konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg