D17492: Be explicit on what the ViewContainer accepts

[Kurt Hindenburg]

hindenburg added a comment.


  If you can comment on the foreach removals, I don't see any other issues ATM

INLINE COMMENTS

> ViewContainer.cpp:471
>  {
> -    foreach (QWidget *widget, widgetsForItem(item)) {
> -        const int index = indexOf(widget);
> -
> -        if (index != currentIndex()) {
> -            setTabActivity(index, true);
> -        }
> +    auto controller = qobject_cast<SessionController*>(item);
> +    auto index = indexOf(controller->view());

The only think that looks odd to me is you removed a couple of these foreach widgetsForItems loops.  Are you sure that's what you wanted?

471, 489, 493

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D17492

To: tcanabrava, #konsole, hindenburg
Cc: konsole-devel, thsurrel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181212/438d5aff/attachment.html>