D17267: Don't duplicate the tabs when Spliting the View

[Tomaz Canabrava]

tcanabrava added a comment.


  As usual thanks for the really good review.
  I’ll address the Points tomorrow as today I’m traveling.
  
  The detach tabs I believe that it takes the size of the terminal display;
  probably it’s something that’s broken with the current behavior already.
  
  The point two seems easy to fix.
  And I believe the fix for point three is the same for point two.
  
  I need to focus the newly created tab for point 3. And I need to focus the
  current tab for point 2.
  
  Em sáb, 8 de dez de 2018 às 18:16, Kurt Hindenburg <
  noreply at phabricator.kde.org> escreveu:
  
  > hindenburg added a comment. View Revision
  >  https://phabricator.kde.org/D17267
  > 
  > I've noticed a few issues
  > 
  > 1. detach split tabs maintain the same size (ie not the full window) but the size the tab was - is this expected behavior?
  > 2. close one side of the view causing the menus to not have all the menus until switching tabs
  > 3. opening a new tab on the non-focus side will not update the tab text (ie should be "src:zsh", it is ":" until you click on tab).
  > 
  > *REPOSITORY*
  >  R319 <https://phabricator.kde.org/source/konsole/> Konsole
  > 
  > *BRANCH*
  > dontDuplicateTabs
  > 
  > *REVISION DETAIL*
  >  https://phabricator.kde.org/D17267
  > 
  > *To: *tcanabrava, thsurrel, hindenburg, gennad, ngraham, Konsole
  >  *Cc: *ngraham, hindenburg, gennad, konsole-devel, thsurrel,
  > maximilianocuria

REPOSITORY
  R319 Konsole

BRANCH
  dontDuplicateTabs

REVISION DETAIL
  https://phabricator.kde.org/D17267

To: tcanabrava, thsurrel, hindenburg, gennad, ngraham, #konsole
Cc: ngraham, hindenburg, gennad, konsole-devel, thsurrel, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181208/06f07112/attachment.html>