Review Request 130133: Fix Screen::scrollUp() behavior

[Octoploid Octoploid]

> On June 2, 2017, 3:13 a.m., Kurt Hindenburg wrote:
> > Using tmux master, Konsole crashes immediately: ASSERT: "sourceBegin <= sourceEnd"
> > 
> > Is this patch correct?
> 
> Kurt Hindenburg wrote:
>     ASSERT: "sourceBegin <= sourceEnd" in file /mnt/projects/Devel/KDE/src/kde/applications/konsole/src/Screen.cpp, line 878

I've updated the patch. It doesn't hit the assertion anymore.
But I've just quickly hacked something together that seems to work, without fully understanding the code.


- Octoploid


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130133/#review103263
-----------------------------------------------------------


On June 2, 2017, 5:44 a.m., Octoploid Octoploid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130133/
> -----------------------------------------------------------
> 
> (Updated June 2, 2017, 5:44 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 379318
>     http://bugs.kde.org/show_bug.cgi?id=379318
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Patch from Nicholas Marriott (of tmux fame).
> See: https://github.com/tmux/tmux/issues/931
> 
> Currently Screen::scrollUp() is broken and cannot be used by tmux.
> ("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a workaround)
> 
> Fix the issue by copying the checks in Screen::scrollDown().
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp 90671829bf9b 
> 
> Diff: https://git.reviewboard.kde.org/r/130133/diff/
> 
> 
> Testing
> -------
> 
> Tested with tmux trunk.
> 
> 
> Thanks,
> 
> Octoploid Octoploid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170602/491a0418/attachment.html>