Review Request 130133: Fix Screen::scrollUp() behavior
Octoploid Octoploid
octoploid at yandex.com
Fri Jun 2 05:44:11 UTC 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130133/
-----------------------------------------------------------
(Updated June 2, 2017, 5:44 a.m.)
Review request for Konsole and Kurt Hindenburg.
Changes
-------
Fix off by one issue
Bugs: 379318
http://bugs.kde.org/show_bug.cgi?id=379318
Repository: konsole
Description
-------
Patch from Nicholas Marriott (of tmux fame).
See: https://github.com/tmux/tmux/issues/931
Currently Screen::scrollUp() is broken and cannot be used by tmux.
("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a workaround)
Fix the issue by copying the checks in Screen::scrollDown().
Diffs (updated)
-----
src/Screen.cpp 90671829bf9b
Diff: https://git.reviewboard.kde.org/r/130133/diff/
Testing
-------
Tested with tmux trunk.
Thanks,
Octoploid Octoploid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170602/2c17517a/attachment.html>
More information about the konsole-devel
mailing list