Review Request 129874: Limit ourselves to 3 combining characters

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sun Jan 22 21:18:28 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129874/
-----------------------------------------------------------

(Updated Jan. 22, 2017, 9:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit a593f29e2441158ade667992cbf36900727bbb08 by Martin T. H. Sandsmark to branch master.


Repository: konsole


Description
-------

This seems to be the maximum in all the test files I've been trying. Without this we get an issue with too many combining characters where Konsole will eventually just hang.


Diffs
-----

  src/Screen.cpp 0b3124a5 
  tests/combining.py PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129874/diff/


Testing
-------

Test case which breaks Konsole without this patch added.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170122/c00732cf/attachment.html>


More information about the konsole-devel mailing list