Review Request 129874: Limit ourselves to 3 combining characters

Kurt Hindenburg kurt.hindenburg at gmail.com
Sun Jan 22 20:47:16 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129874/#review102191
-----------------------------------------------------------


Ship it!




good - want to throw the .py into tests folder?

- Kurt Hindenburg


On Jan. 22, 2017, 8:02 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129874/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2017, 8:02 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This seems to be the maximum in all the test files I've been trying. Without this we get an issue with too many combining characters where Konsole will eventually just hang.
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp 0b3124a5 
>   tests/combining.py PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129874/diff/
> 
> 
> Testing
> -------
> 
> Test case which breaks Konsole without this patch added.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170122/a25018ec/attachment.html>


More information about the konsole-devel mailing list