Review Request 129841: Handle surrogate utf16 characters

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sun Jan 22 19:11:18 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129841/
-----------------------------------------------------------

(Updated Jan. 22, 2017, 7:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 1c13e4841d76e96b7a3da12bc629202e9fd71c5d by Martin T. H. Sandsmark to branch master.


Repository: konsole


Description
-------

For our own sanity we (falsely) assume that all surrogate characters are double width, otherwise we have to go back and reflow the line...

This makes it work better with emojis in vim at least.


Diffs
-----

  src/Screen.cpp d674017b 
  src/konsole_wcwidth.cpp 39c23076 

Diff: https://git.reviewboard.kde.org/r/129841/diff/


Testing
-------

It handles ???? (U+1F4A9) properly in vim.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170122/fd3a4258/attachment.html>


More information about the konsole-devel mailing list