Review Request 129841: Handle surrogate utf16 characters

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129841/#review102162
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On Jan. 15, 2017, 4:01 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129841/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 4:01 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> For our own sanity we (falsely) assume that all surrogate characters are double width, otherwise we have to go back and reflow the line...
> 
> This makes it work better with emojis in vim at least.
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp d674017b 
>   src/konsole_wcwidth.cpp 39c23076 
> 
> Diff: https://git.reviewboard.kde.org/r/129841/diff/
> 
> 
> Testing
> -------
> 
> It handles ???? (U+1F4A9) properly in vim.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20170121/11d18ad9/attachment.html>