Review Request 128827: Fix scrolling down if user presses something that is not just a modifier

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128827/
-----------------------------------------------------------

(Updated Sept. 4, 2016, 9:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 54ecd560b8d76121256a0bd653999fb8d4acb363 by Martin T. H. Sandsmark to branch master.


Repository: konsole


Description
-------

If the user presses e. g. arrow up, we should actually scroll down. What I intended to fix was only the case where the user only pressed a modifier.

And hardcoding a list of keys and behaviors is bad and bug prone, so I think this is the best solution.


Diffs
-----

  src/SessionController.cpp a1db8bc 

Diff: https://git.reviewboard.kde.org/r/128827/diff/


Testing
-------

Scroll up, press arrow up to go to previous item in history, and watch it scroll down.

For the issue the previous change fixed, scroll up, press meta, click in the terminal, and watch it not scroll down.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160904/c14cb110/attachment-0001.html>