Review Request 128827: Fix scrolling down if user presses something that is not just a modifier

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128827/#review98880
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On Sept. 4, 2016, 10:18 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128827/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2016, 10:18 a.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> If the user presses e. g. arrow up, we should actually scroll down. What I intended to fix was only the case where the user only pressed a modifier.
> 
> And hardcoding a list of keys and behaviors is bad and bug prone, so I think this is the best solution.
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp a1db8bc 
> 
> Diff: https://git.reviewboard.kde.org/r/128827/diff/
> 
> 
> Testing
> -------
> 
> Scroll up, press arrow up to go to previous item in history, and watch it scroll down.
> 
> For the issue the previous change fixed, scroll up, press meta, click in the terminal, and watch it not scroll down.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160904/502e427f/attachment.html>