Review Request 129214: Added possibility to give default dir on Part instantiation

Sven Fischer sven at leiderfischer.de
Thu Oct 27 06:44:50 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129214/
-----------------------------------------------------------

(Updated Okt. 27, 2016, 6:44 vorm.)


Review request for Konsole.


Changes
-------

Applied the changes to iterating the QVariantList and using the QVariantMap


Repository: konsole


Description (updated)
-------

On konsole KPart instantiation, the QVariantList is evaluated for a
default directory to change to. The Part honors the profile setting "Use
same directory...". If it is not set, the directory is ignored.

Simplified the argument parsing

Beautified the source by using C++11 iteration and QVariantMap


Diffs (updated)
-----

  src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d 

Diff: https://git.reviewboard.kde.org/r/129214/diff/


Testing
-------

Built a new version of yakuake against this konsolepart.so. Worked perfectly.


Thanks,

Sven Fischer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161027/4f932fac/attachment.html>


More information about the konsole-devel mailing list