Review Request 129214: Added possibility to give default dir on Part instantiation

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129214/#review100210
-----------------------------------------------------------



Sorry, I'm a bit confused.

Isn't this what the «Part::createSession(QString profileName, QString directory);» is for? And where is the QVariantList coming from? I can't find it referenced in the readonlypart.h header nor in the kde_terminal_interface.h header.


src/Part.cpp (line 78)
<https://git.reviewboard.kde.org/r/129214/#comment67300>

    Why an iterator instead of e. g. a «for (const QVariant &variant : defaults)» or something?



src/Part.cpp (line 80)
<https://git.reviewboard.kde.org/r/129214/#comment67301>

    IMHO QVariantMap is marginally prettier.


- Martin Tobias Holmedahl Sandsmark


On Oct. 18, 2016, 4:58 p.m., Sven Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129214/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2016, 4:58 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> On konsole KPart instantiation, the QVariantList is evaluated for a
> default directory to change to. The Part honors the profile setting "Use
> same directory...". If it is not set, the directory is ignored.
> 
> 
> Diffs
> -----
> 
>   src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d 
> 
> Diff: https://git.reviewboard.kde.org/r/129214/diff/
> 
> 
> Testing
> -------
> 
> Built a new version of yakuake against this konsolepart.so. Worked perfectly.
> 
> 
> Thanks,
> 
> Sven Fischer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161022/98f2f8b5/attachment.html>