Review Request 129343: Silence ubsan warnings

[Martin Tobias Holmedahl Sandsmark]

> On Nov. 7, 2016, 7:10 p.m., Kurt Hindenburg wrote:
> > top 2 look reasonable - bottom one we had issues w/ crashes in the past I think - if you sure it is valid, go ahead

Well, qobject_cast or dynamic_cast could crash (at least on the Q_ASSERT below), but reinterpret_cast should be safe as long as we don't dereference the pointer (which would crash anyway since the object is destroyed).


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129343/#review100695
-----------------------------------------------------------


On Nov. 9, 2016, 12:39 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129343/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 12:39 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Not really sure if all these matter, they're all inconsequential warnings about invalid pointer casts.
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 0e286e4 
>   src/TerminalDisplay.cpp a609c19 
>   src/ViewManager.cpp 81ccab1 
> 
> Diff: https://git.reviewboard.kde.org/r/129343/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161109/4329ce49/attachment.html>