Review Request 129343: Silence ubsan warnings

Kurt Hindenburg kurt.hindenburg at gmail.com
Mon Nov 7 19:10:34 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129343/#review100695
-----------------------------------------------------------


Ship it!




top 2 look reasonable - bottom one we had issues w/ crashes in the past I think - if you sure it is valid, go ahead

- Kurt Hindenburg


On Nov. 5, 2016, 5:15 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129343/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 5:15 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Not really sure if all these matter, they're all inconsequential warnings about invalid pointer casts.
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 0e286e4 
>   src/TerminalDisplay.cpp a609c19 
>   src/ViewManager.cpp 81ccab1 
> 
> Diff: https://git.reviewboard.kde.org/r/129343/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161107/d9bb6cb5/attachment.html>


More information about the konsole-devel mailing list