Review Request 129342: Fix randomization in color scheme

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129342/
-----------------------------------------------------------

(Updated Nov. 9, 2016, 12:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 3ff022527e53cd5daa6fe8589de81b5988457945 by Martin T. H. Sandsmark to branch master.


Repository: konsole


Description
-------

Use the new std::random APIs in c++11 for generating random numbers which is much safer and doesn't abuse qsrand().

This also means we don't need to copy in the QUuid::createUuid() code anymore, which generated a warning in ubsan.


Diffs
-----

  src/ColorScheme.cpp a85072b 
  src/Session.cpp 302bddc 

Diff: https://git.reviewboard.kde.org/r/129342/diff/


Testing
-------

It still generates random colors; all three HSV values are randomized properly and deterministically according to the randomSeed. Doesn't complain about Session::createUuid() anymore.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161109/90b11df6/attachment.html>