Review Request 129342: Fix randomization in color scheme

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129342/#review100689
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On Nov. 5, 2016, 4:43 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129342/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2016, 4:43 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Use the new std::random APIs in c++11 for generating random numbers which is much safer and doesn't abuse qsrand().
> 
> This also means we don't need to copy in the QUuid::createUuid() code anymore, which generated a warning in ubsan.
> 
> 
> Diffs
> -----
> 
>   src/ColorScheme.cpp a85072b 
>   src/Session.cpp 302bddc 
> 
> Diff: https://git.reviewboard.kde.org/r/129342/diff/
> 
> 
> Testing
> -------
> 
> It still generates random colors; all three HSV values are randomized properly and deterministically according to the randomSeed. Doesn't complain about Session::createUuid() anymore.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20161107/73491dfb/attachment.html>