[Konsole-devel] Review Request 128153: Fix potential out of bounds read.

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Fri Jun 17 20:12:57 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated June 17, 2016, 8:12 p.m.)


This change has been marked as submitted.

Review request for Konsole.


Submitted with commit c026b0e4b153d948d0d25856a94498d7946ccfbf by Martin T. H. Sandsmark to branch master.

Repository: konsole


The check was only done when not memory mapped, so there was a potential out of bounds read. In addition the check only printed an error, and didn't return and went ahead with the erronous read.


  src/History.cpp d00b95a 

Diff: https://git.reviewboard.kde.org/r/128153/diff/


Tested running with the unlimited scrollback and various amounts of printing and scrolling to try to trigger both the mmaped and unmmaped cases.


Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160617/c57b841d/attachment.html>

More information about the konsole-devel mailing list