[Konsole-devel] Review Request 128153: Fix potential out of bounds read.

[Kurt Hindenburg]

> On June 11, 2016, 5:13 p.m., Kurt Hindenburg wrote:
> > Yea there some serious issues w/ unlimited history.  The big file is around 2.1G - the code needs fixed to handle larger # and error checks added.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     we could probably start by switching over to longs from ints for lengths and positions?
> 
> Kurt Hindenburg wrote:
>     yes - I never got around to working on it

feel free to commit this if it works for you


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128153/#review96360
-----------------------------------------------------------


On June 11, 2016, 4:37 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128153/
> -----------------------------------------------------------
> 
> (Updated June 11, 2016, 4:37 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> The check was only done when not memory mapped, so there was a potential out of bounds read. In addition the check only printed an error, and didn't return and went ahead with the erronous read.
> 
> 
> Diffs
> -----
> 
>   src/History.cpp d00b95a 
> 
> Diff: https://git.reviewboard.kde.org/r/128153/diff/
> 
> 
> Testing
> -------
> 
> Tested running with the unlimited scrollback and various amounts of printing and scrolling to try to trigger both the mmaped and unmmaped cases.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160616/72d10a29/attachment.html>