[Konsole-devel] Review Request 127525: Fix FreeBSD readArguments, implement its readEnvironment, and massage SSHProcessInfo

Tobias Berner tcberner at gmail.com
Sat Jul 9 22:48:37 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated July 9, 2016, 10:48 p.m.)


This change has been marked as submitted.

Review request for Konsole, Kurt Hindenburg and Raphael Kubo da Costa.

Repository: konsole


1. This contains multiple `ProcessInfo` related changes.                                                                                                                                      
        * FreeBSD's `readArguments()` implementation was broken:                                                                                                                               
          as it read the wrong `sysctl`.                                                                                                                                                       
          Also the string processing did not work as expected.                                                                                                                           
        * FreeBSD's `readEnvironment()` was not implemented.                                                                                                                                   
          This provides an implementation using `libprocstat`'s                                                                                                                                
2. `SSHProcessInfo` related changes:                                                                                                                                                          
        * `_command` was only set to the last argument in the list.                                                                                                                            
          Modify it to include every element after `_host` has been                                                                                                                          
          Before "ssh host top -d 50" would display '50' as the command.                                                                                                                     
          Now it should be 'top -d 50'.                                                                                                                                                      
        * Add a new string replacement `%U` for remote tabs, which evaluates                                                                                                                   
              to `_user@` if user is non-empty, and the emptystring otherwise.


  src/CMakeLists.txt 6798079 
  src/ProcessInfo.cpp 1f5505a 

Diff: https://git.reviewboard.kde.org/r/127525/diff/


Tested locally.


Tobias Berner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160709/d97a07af/attachment.html>

More information about the konsole-devel mailing list