[Konsole-devel] Review Request 127525: Fix FreeBSD readArguments, implement its readEnvironment, and massage SSHProcessInfo

[Kurt Hindenburg]

> On July 9, 2016, 6 p.m., Kurt Hindenburg wrote:
> > The FreeBSD part committed in http://commits.kde.org/konsole/2c93676978b2267ad043ea1b5a63c0342672e9b8
> > 
> > I'll do the SSH part separately.

Thanks again
d424d1457d4cfbe5449f8d772a596324e674665c - ssh arguments
a805f856ff81b80ff1f6c1f70934ea89a4ca3414 - %U


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127525/#review97242
-----------------------------------------------------------


On March 30, 2016, 12:19 p.m., Tobias Berner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127525/
> -----------------------------------------------------------
> 
> (Updated March 30, 2016, 12:19 p.m.)
> 
> 
> Review request for Konsole, Kurt Hindenburg and Raphael Kubo da Costa.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> 1. This contains multiple `ProcessInfo` related changes.                                                                                                                                      
>         * FreeBSD's `readArguments()` implementation was broken:                                                                                                                               
>           as it read the wrong `sysctl`.                                                                                                                                                       
>           Also the string processing did not work as expected.                                                                                                                           
>         * FreeBSD's `readEnvironment()` was not implemented.                                                                                                                                   
>           This provides an implementation using `libprocstat`'s                                                                                                                                
>           `procstat_getenvv`                                                                                                                                                            
>                                                                                                                                                                                              
> 2. `SSHProcessInfo` related changes:                                                                                                                                                          
>         * `_command` was only set to the last argument in the list.                                                                                                                            
>           Modify it to include every element after `_host` has been                                                                                                                          
>           set.                                                                                                                                                                               
>           Before "ssh host top -d 50" would display '50' as the command.                                                                                                                     
>           Now it should be 'top -d 50'.                                                                                                                                                      
>         * Add a new string replacement `%U` for remote tabs, which evaluates                                                                                                                   
>               to `_user@` if user is non-empty, and the emptystring otherwise.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6798079 
>   src/ProcessInfo.cpp 1f5505a 
> 
> Diff: https://git.reviewboard.kde.org/r/127525/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Tobias Berner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160709/2cfc9288/attachment-0001.html>