[Konsole-devel] Review Request 128346: Port to QRegularExpression

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128346/#review97220
-----------------------------------------------------------



Somewhere in these patches, when you click the X in the Text field to clear the search term, the horizontal line of last search is not cleared.

- Kurt Hindenburg


On July 7, 2016, 8:06 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128346/
> -----------------------------------------------------------
> 
> (Updated July 7, 2016, 8:06 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Port away from using QRegExp to QRegularExpression. The result is a bit better performance, a bit more readable code (imho) and also no more relying on mutable state in static objects (like in the keyboard translator parser).
> 
> 
> Diffs
> -----
> 
>   src/Filter.h 1790bd9 
>   src/Filter.cpp b3f0186 
>   src/KeyboardTranslator.cpp 3effb72 
>   src/Profile.cpp 9b2201f 
>   src/SessionController.h 7b357e5 
>   src/SessionController.cpp 58e2f81 
> 
> Diff: https://git.reviewboard.kde.org/r/128346/diff/
> 
> 
> Testing
> -------
> 
> Tested all the affected code individually.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160708/7516ffd5/attachment.html>