[Konsole-devel] Review Request 128346: Port to QRegularExpression

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128346/
-----------------------------------------------------------

(Updated July 7, 2016, 8:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit 1d20e43ea9ebdc977b400ff35b3d200202f0c474 by Martin T. H. Sandsmark to branch master.


Repository: konsole


Description
-------

Port away from using QRegExp to QRegularExpression. The result is a bit better performance, a bit more readable code (imho) and also no more relying on mutable state in static objects (like in the keyboard translator parser).


Diffs
-----

  src/Filter.h 1790bd9 
  src/Filter.cpp b3f0186 
  src/KeyboardTranslator.cpp 3effb72 
  src/Profile.cpp 9b2201f 
  src/SessionController.h 7b357e5 
  src/SessionController.cpp 58e2f81 

Diff: https://git.reviewboard.kde.org/r/128346/diff/


Testing
-------

Tested all the affected code individually.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160707/8fbe21be/attachment.html>