[Konsole-devel] Review Request 128389: Preserve current line when resetting display.

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128389/#review97179
-----------------------------------------------------------



I don't really have an opinion on this.  I notice you get different results depending on what shell you're using w/ all the terminals. If you think this is correct, go ahead and commit it.

- Kurt Hindenburg


On July 6, 2016, 4:03 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128389/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 4:03 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> When resetting the display preserve the last line.
> 
> This matches what e. g. uxterm, urxvt or OS X Terminal seems to be doing (I tested in uxterm and urxvt, and according to people on the internet Terminal does the same).
> 
> 
> Diffs
> -----
> 
>   src/Screen.h a53aa45 
>   src/Screen.cpp 8e05249 
> 
> Diff: https://git.reviewboard.kde.org/r/128389/diff/
> 
> 
> Testing
> -------
> 
> Tested running «printf "\ec"», running «reset» (behaves as before this patch) and selecting «clear scrollback and reset».
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160707/f30d0dda/attachment.html>