[Konsole-devel] Review Request 128389: Preserve current line when resetting display.

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128389/
-----------------------------------------------------------

(Updated July 6, 2016, 4:03 p.m.)


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Reset was always called with clearScreen = true, so no point in having that variable. We can probably also remove Screen::clear() and Screen::home(), they're not used anymore, and weren't really useful before this either.

We still preserve the scrollback history when resetting, which is not what other terminal emulators do (http://stackoverflow.com/a/5367075), but we do have a separate action for it, so I think it is a nice extra feature to preserve it.


Repository: konsole


Description
-------

When resetting the display preserve the last line.

This matches what e. g. uxterm, urxvt or OS X Terminal seems to be doing (I tested in uxterm and urxvt, and according to people on the internet Terminal does the same).


Diffs (updated)
-----

  src/Screen.h a53aa45 
  src/Screen.cpp 8e05249 

Diff: https://git.reviewboard.kde.org/r/128389/diff/


Testing
-------

Tested running «printf "\ec"», running «reset» (behaves as before this patch) and selecting «clear scrollback and reset».


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160706/385ab052/attachment.html>