[Konsole-devel] Review Request 128391: Fix rendering of decomposed Hangul
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Wed Jul 6 21:00:54 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128391/
-----------------------------------------------------------
(Updated July 6, 2016, 9 p.m.)
Status
------
This change has been marked as submitted.
Review request for Konsole, Eike Hein and Kurt Hindenburg.
Repository: konsole
Description
-------
When looking backwards to combine into a character, it didn't take into
account characters with two column width. It also assumed that all
characters that needed to be combined were in the Mn unicode character
category, while the Hangul starting consonants are in the Lo category.
Diffs
-----
src/Screen.cpp 8e05249
Diff: https://git.reviewboard.kde.org/r/128391/diff/
Testing
-------
new: https://iskrembilen.com/screenshots/arabisk1.png
vs old: https://iskrembilen.com/screenshots/arabisk2.png
Thanks,
Martin Tobias Holmedahl Sandsmark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160706/309a26f5/attachment-0001.html>
More information about the konsole-devel
mailing list