[Konsole-devel] Review Request 128391: Fix rendering of decomposed Hangul

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128391/#review97169
-----------------------------------------------------------


Ship it!




Ship It!

- Eike Hein


On July 6, 2016, 8:31 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128391/
> -----------------------------------------------------------
> 
> (Updated July 6, 2016, 8:31 p.m.)
> 
> 
> Review request for Konsole, Eike Hein and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> When looking backwards to combine into a character, it didn't take into
>     account characters with two column width. It also assumed that all
>     characters that needed to be combined were in the Mn unicode character
>     category, while the Hangul starting consonants are in the Lo category.
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp 8e05249 
> 
> Diff: https://git.reviewboard.kde.org/r/128391/diff/
> 
> 
> Testing
> -------
> 
> new: https://iskrembilen.com/screenshots/arabisk1.png 
> vs old: https://iskrembilen.com/screenshots/arabisk2.png
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160706/0c0e394b/attachment.html>