[Konsole-devel] Review Request 128239: Don't show silence/activity notifications when the terminal is active

[Martin Tobias Holmedahl Sandsmark]

> On June 18, 2016, 9:32 p.m., Kurt Hindenburg wrote:
> > THe code looks fine.  However, are we sure there aren't reason why someone might want notifications on the active tab?  Say, start a command; walk away, do something non-computer related - waiting for notifiction.  Or is this a rare usage?
> 
> Martin Tobias Holmedahl Sandsmark wrote:
>     Hmm, good point, didn't consider that some people do non-computer related things. :-)
>     
>     I guess we could put in a setting for this?
> 
> Kurt Hindenburg wrote:
>     Yes I guess that'd be best - otherwise we'll get bug reports.

Now it has separate notifications for hidden/visible triggers, similar to the bell notifications.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128239/#review96693
-----------------------------------------------------------


On July 2, 2016, 9:10 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128239/
> -----------------------------------------------------------
> 
> (Updated July 2, 2016, 9:10 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 257752
>     http://bugs.kde.org/show_bug.cgi?id=257752
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> This avoids getting constant notifications when using a session which has the monitor activity/silence option turned on.
> 
> You still get notifications if konsole isn't focused or you're in another session/tab.
> 
> 
> Diffs
> -----
> 
>   desktop/konsole.notifyrc a2721cf 
>   src/Session.cpp 0520628 
> 
> Diff: https://git.reviewboard.kde.org/r/128239/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160706/8f639efd/attachment.html>