[Konsole-devel] Review Request 128346: Port to QRegularExpression
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Sat Jul 2 19:40:22 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128346/
-----------------------------------------------------------
Review request for Konsole and Kurt Hindenburg.
Repository: konsole
Description
-------
Port away from using QRegExp to QRegularExpression. The result is a bit better performance, a bit more readable code (imho) and also no more relying on mutable state in static objects (like in the keyboard translator parser).
Diffs
-----
src/Filter.h 8d125f2
src/Filter.cpp 789c4cd
src/KeyboardTranslator.cpp 3effb72
src/Profile.cpp 287b047
src/SessionController.h 32a9e7c
src/SessionController.cpp b37937d
Diff: https://git.reviewboard.kde.org/r/128346/diff/
Testing
-------
Tested all the affected code individually.
Thanks,
Martin Tobias Holmedahl Sandsmark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160702/6fb2aace/attachment.html>
More information about the konsole-devel
mailing list