Review Request 128791: Only send EOF if the process that was started was a normal shell

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128791/#review98756
-----------------------------------------------------------


Ship it!




Is this still needed w/ 392ee33cf8ffec54d41d342d7cba8fe82a13adc0 ?  or is this another layer to verify the bug is fixed?

Also, perhaps change the comment in the middle  s/default/known/

- Kurt Hindenburg


On Aug. 28, 2016, 5:32 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128791/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2016, 5:32 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 367746
>     http://bugs.kde.org/show_bug.cgi?id=367746
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> The only processes that are "safe" or require us to send an EOF to terminate cleanly are shells, so verify that people didn't run with -e tmux or similar.
> 
> 
> Diffs
> -----
> 
>   src/Session.cpp 9178eb2 
> 
> Diff: https://git.reviewboard.kde.org/r/128791/diff/
> 
> 
> Testing
> -------
> 
> Normal bash gets EOF, -e tmux gets SIGHUP.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160828/8877a985/attachment-0001.html>