Review Request 128791: Only send EOF if the process that was started was a normal shell

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sun Aug 28 17:32:40 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128791/
-----------------------------------------------------------

Review request for Konsole.


Bugs: 367746
    http://bugs.kde.org/show_bug.cgi?id=367746


Repository: konsole


Description
-------

The only processes that are "safe" or require us to send an EOF to terminate cleanly are shells, so verify that people didn't run with -e tmux or similar.


Diffs
-----

  src/Session.cpp 9178eb2 

Diff: https://git.reviewboard.kde.org/r/128791/diff/


Testing
-------

Normal bash gets EOF, -e tmux gets SIGHUP.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160828/2d45389a/attachment.html>


More information about the konsole-devel mailing list