Review Request 128669: Fix transparent backgrounds

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128669/
-----------------------------------------------------------

(Updated Aug. 13, 2016, 9:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit a28902e9120798c67844864a11bbe3f1c2549b74 by Martin T. H. Sandsmark to branch master.


Bugs: 366368
    http://bugs.kde.org/show_bug.cgi?id=366368


Repository: konsole


Description
-------

It's apparently not possible to set WA_TranslucentBackground after show(). The MainWindow constructor calls applyKonsoleSettings() which calls KMainWindow::setAutoSaveSettings() which in turn calls setVisible(true), which makes any calls to setTransparency() from the Application::newMainWindow() irrelevant, even if updateUseTransparency() is called from it.


Diffs
-----

  src/Application.cpp cbd1373 
  src/MainWindow.h 978bd93 
  src/MainWindow.cpp cae8a54 

Diff: https://git.reviewboard.kde.org/r/128669/diff/


Testing
-------

Transparent backgrounds work, tested starting without a compositor, killing the compositor, etc.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160813/57ffeaec/attachment.html>