Review Request 128669: Fix transparent backgrounds

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128669/#review98361
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On Aug. 13, 2016, 1:47 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128669/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 1:47 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Bugs: 366368
>     http://bugs.kde.org/show_bug.cgi?id=366368
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> It's apparently not possible to set WA_TranslucentBackground after show(). The MainWindow constructor calls applyKonsoleSettings() which calls KMainWindow::setAutoSaveSettings() which in turn calls setVisible(true), which makes any calls to setTransparency() from the Application::newMainWindow() irrelevant, even if updateUseTransparency() is called from it.
> 
> 
> Diffs
> -----
> 
>   src/Application.cpp cbd1373 
>   src/MainWindow.h 978bd93 
>   src/MainWindow.cpp cae8a54 
> 
> Diff: https://git.reviewboard.kde.org/r/128669/diff/
> 
> 
> Testing
> -------
> 
> Transparent backgrounds work, tested starting without a compositor, killing the compositor, etc.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20160813/3a85471e/attachment.html>