[Konsole-devel] Review Request 125366: Fix heap-use-after-free in Part destructor

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125366/
-----------------------------------------------------------

(Updated Sept. 24, 2015, 12:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konsole and Kurt Hindenburg.


Changes
-------

Submitted with commit ace53ef482c621b375eea2d9b38eda6b11b69873 by Albert Astals Cid to branch Applications/15.08.


Repository: konsole


Description
-------

Tear down the ViewManager on the Part destructor instead of letting Qt destroy the child objects itself.

This way we control the sequence more and make sure we don't end up using memory that was already deleted. Fixes the ASAN detected problem in https://build.kde.org/job/konsole%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/testReport/%28root%29/TestSuite/PartTest/


Diffs
-----

  src/Part.cpp 63b5664 

Diff: https://git.reviewboard.kde.org/r/125366/diff/


Testing
-------

Neither ASAN nor valgrind complain anymore when running PartTest.


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150924/00db8687/attachment.html>