[Konsole-devel] Review Request 125366: Fix heap-use-after-free in Part destructor

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125366/#review85866
-----------------------------------------------------------

Ship it!


looks fine thanks - might as well put in 15.08.x as well

- Kurt Hindenburg


On Sept. 23, 2015, 9:57 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125366/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2015, 9:57 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Tear down the ViewManager on the Part destructor instead of letting Qt destroy the child objects itself.
> 
> This way we control the sequence more and make sure we don't end up using memory that was already deleted. Fixes the ASAN detected problem in https://build.kde.org/job/konsole%20Applications-15.08%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/testReport/%28root%29/TestSuite/PartTest/
> 
> 
> Diffs
> -----
> 
>   src/Part.cpp 63b5664 
> 
> Diff: https://git.reviewboard.kde.org/r/125366/diff/
> 
> 
> Testing
> -------
> 
> Neither ASAN nor valgrind complain anymore when running PartTest.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150924/639bf96b/attachment.html>