[Konsole-devel] Review Request 124739: Set tabs movable again

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124739/#review83906
-----------------------------------------------------------

Ship it!


Whoa nice job!  This fixes moving of tabs and also dragging a tab outside its window to create another window.  Thanks a lot.

- Kurt Hindenburg


On Aug. 16, 2015, 9:43 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124739/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2015, 9:43 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> KTabBar used to do internal drag & drop re-ordering
> Konsole massively expanded on this to do cross window drag & drop.
> 
> Now Qt does tabbar reordering, but Konsole relied on KTabBar's signals
> to say when a drag start before overriding the rest.
> 
> To solve this I've added the same drag start signal manually into
> Konsole's tab bar.
> 
> BUG: 348057
> 
> 
> Diffs
> -----
> 
>   src/ViewContainer.cpp 02be309fbd22cf52ea963bbd11c0e589b1e5004a 
>   src/ViewContainerTabBar.h 0e2985fd53021edbc9f5fb58aeadd40c564728bf 
>   src/ViewContainerTabBar.cpp 399c391d619d23b34bb03be9f61417931f80ee51 
> 
> Diff: https://git.reviewboard.kde.org/r/124739/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20150817/019ce580/attachment-0001.html>